There are lots of roses that make good hips. I think you will find rugosas near the tops of most lists: Hansa and Rugosa Alba might be good choices.
I went to the trouble of tasting many of the rose hips produced in my garden last year and I found the best tasting (fresh) to be on a rose that I never ordered, which I presume to be Bishop Darlington.
A terrrific rose South Africa makes hips, but in my garden they are a little bitter. Other roses in my own garden with hips include Lady Pamela Carol and Tess of the d'Ubervilles, both good roses.
I believe Heirloom Roses has a good list of roses with hips to complement their very deep catalogue. And Antique Rose Emporium's catalogue will generally indicate if a rose is notable for its hips.
